Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for image pull secrets for backups and restores #1670

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

tylergmuir
Copy link
Contributor

SUMMARY

This adds support for using image_pull_secrets when using AWXBackup or AWXRestore to match the functionality of the AWX install.

Fixes #1669
Fixes #816

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

@tylergmuir
Copy link
Contributor Author

A quick note on this, I opted to only add support for image_pull_secrets and not image_pull_secret since the latter is deprecated. This does mean that if someone was using image_pull_secret and just copied the options in the spec straight across to the spec for a backup/restore it would not work.

Since the image_pull_secret option has been deprecated for over 18 months and this is brand new functionality (with documentation), I think is fair. But I am open to other opinions on the matter.

Copy link
Member

@rooftopcellist rooftopcellist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylergmuir These changes look great! There is just one thing that needs to be added before merging. Could you add an entry like this in the AWXBackup and AWXRestore section of this same CSV file?

@tylergmuir
Copy link
Contributor Author

@tylergmuir These changes look great! There is just one thing that needs to be added before merging. Could you add an entry like this in the AWXBackup and AWXRestore section of this same CSV file?

@rooftopcellist this is completed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants