Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the user.py file of line 920 to line 924 for using tilde issues #82494

Closed
wants to merge 7 commits into from

Conversation

hydromelvictor
Copy link

SUMMARY

resolution of tilde expansion when checking equality between the desired shell and the one already in use

Fixes #82490

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

I used os.path.expanduser to expand the tilde in the shell path before comparing the values


@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 6, 2024
@ansibot
Copy link
Contributor

ansibot commented Jan 6, 2024

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:921:38: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 6, 2024

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:922:38: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2024

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:921:54: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2024

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/user.py:0:0: doc-type-does-not-match-spec: Argument 'shell' in argument_spec defines type as 'path' but documentation defines type as 'str'

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:921:54: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2024

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:921:58: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2024

The test ansible-test sanity --test use-argspec-type-path [explain] failed with 1 error:

lib/ansible/modules/user.py:922:54: use argspec type="path" instead of type="str" to avoid use of `expanduser`

click here for bot help

@Akasurde
Copy link
Member

Akasurde commented Jan 8, 2024

Duplicate of #82495

@Akasurde Akasurde marked this as a duplicate of #82495 Jan 8, 2024
@Akasurde Akasurde closed this Jan 8, 2024
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 8, 2024
@hydromelvictor hydromelvictor deleted the hydromelvictor branch January 9, 2024 15:23
@ansible ansible locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating user directory using tilde always reports "changed"
4 participants