Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential sub form tests #2319

Merged
merged 2 commits into from
May 29, 2024
Merged

Credential sub form tests #2319

merged 2 commits into from
May 29, 2024

Conversation

AlexSCorey
Copy link
Member

This brings in tests for the credential sub form. The tests simply confirm the existence of the necessary fields, and whether those fields are required.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX CCT Component tests labels May 15, 2024
@kialam
Copy link
Member

kialam commented May 15, 2024

These tests look good. I wonder if it makes sense, since the subform is rendered dynamically based on the credential type selected in the main form, to have the tests assert the correct behavior is happening, vs using hard-coded values. For example, selecting Machine from the dropdown should render all fields as returned by the mock payload (inputs.fields) for credential_type === machine.

@AlexSCorey AlexSCorey force-pushed the 23102-SecreManagementonCredDeets branch from 51a2cad to 6649e39 Compare May 20, 2024 16:11
@AlexSCorey AlexSCorey enabled auto-merge (squash) May 20, 2024 16:11
@AlexSCorey AlexSCorey force-pushed the 23102-SecreManagementonCredDeets branch 3 times, most recently from 5cfeefe to 88aa204 Compare May 28, 2024 14:48
@AlexSCorey AlexSCorey force-pushed the 23102-SecreManagementonCredDeets branch from 88aa204 to 33467f4 Compare May 29, 2024 13:26
@AlexSCorey AlexSCorey force-pushed the 23102-SecreManagementonCredDeets branch from 33467f4 to 020e54b Compare May 29, 2024 14:51
@github-actions github-actions bot added the E2E End-to-end testing label May 29, 2024
@AlexSCorey AlexSCorey merged commit 03f65b3 into main May 29, 2024
17 checks passed
@AlexSCorey AlexSCorey deleted the 23102-SecreManagementonCredDeets branch May 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants