Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook up edit credential form to Credential Plugins wizard. #2314

Merged
merged 4 commits into from
May 16, 2024
Merged

Hook up edit credential form to Credential Plugins wizard. #2314

merged 4 commits into from
May 16, 2024

Conversation

kialam
Copy link
Member

@kialam kialam commented May 14, 2024

Screenshot 2024-05-14 at 4 00 50 PM

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label May 14, 2024
@kialam kialam force-pushed the credential-edit-form-credential-plugin branch from 6503b1d to 4b4cbfd Compare May 15, 2024 17:42
@kialam kialam marked this pull request as ready for review May 15, 2024 18:34
@kialam kialam force-pushed the credential-edit-form-credential-plugin branch from 4b4cbfd to d4598de Compare May 15, 2024 18:41
nixocio
nixocio approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this code locally, and it is working good so far. Great job @kialam

@github-actions github-actions bot added the AFW Ansible Framework label May 15, 2024
skochay330
skochay330 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@skochay330 skochay330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@kialam kialam force-pushed the credential-edit-form-credential-plugin branch 2 times, most recently from 54f29f6 to a0d9ec4 Compare May 16, 2024 16:54
@kialam kialam enabled auto-merge (squash) May 16, 2024 16:54
@kialam kialam force-pushed the credential-edit-form-credential-plugin branch from a0d9ec4 to 6d5c751 Compare May 16, 2024 18:59
@kialam kialam force-pushed the credential-edit-form-credential-plugin branch from 6d5c751 to 6fb38cf Compare May 16, 2024 22:02
@kialam kialam merged commit 7a66f25 into main May 16, 2024
17 checks passed
@kialam kialam deleted the credential-edit-form-credential-plugin branch May 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixocio nixocio nixocio approved these changes

@skochay330 skochay330 skochay330 approved these changes

Assignees
No one assigned
Labels
AFW Ansible Framework AWX Label to indicate changes relevant to AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kialam @nixocio @skochay330