[PR #700/a4c1bd85 backport][stable-3] Update deprecation version for merge_type=json #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Update deprecation version for merge_type=json SUMMARY When looking at the parts of plugins/module_utils/common.py and plugins/module_utils/k8s/service.py during the post 3.0.0 release (see https://github.com/ansible-collections/kubernetes.core/pull/663/files#diff-9ee2d0860a5643da4e1f35136e9e7c3a41c5f2fd2952c197e7e32b941e5a301c) that affect merge_type when set to json, I don't believe merge_type=json was deprecated for (and removed from) the k8s module, and instead the deprecation version has moved to 4.0.0. Hence, the documentation update. ISSUE TYPE Docs Pull Request COMPONENT NAME k8s module Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit a4c1bd8)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s |
gravesm
approved these changes
May 15, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
softwarefactory-project-zuul
bot
merged commit d86a652
into
stable-3
87 of 88 checks passed
gravesm
deleted the
patchback/backports/stable-3/a4c1bd8541167b35f35956396e98fb49ac7e4ec0/pr-700
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #700 as merged into main (a4c1bd8).
SUMMARY
When looking at the parts of
plugins/module_utils/common.pyandplugins/module_utils/k8s/service.pyduring the post3.0.0release (see https://github.com/ansible-collections/kubernetes.core/pull/663/files#diff-9ee2d0860a5643da4e1f35136e9e7c3a41c5f2fd2952c197e7e32b941e5a301c) that affectmerge_typewhen set tojson, I don't believemerge_type=jsonwas deprecated for (and removed from) thek8smodule, and instead the deprecation version has moved to4.0.0. Hence, the documentation update.ISSUE TYPE
COMPONENT NAME
k8smodule