Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s ability to wait on arbitrary property #134

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

k8s ability to wait on arbitrary property #134

wants to merge 27 commits into from

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 15, 2021

SUMMARY

#105 was temporary reverted

ISSUE TYPE
  • Feature Pull Request

abikouo and others added 26 commits May 3, 2021 10:55
@abikouo
missing implementation of jsonpath library
4a9eca5
@abikouo
merge with main branch
06c99d6
@abikouo
not tested
ce037ce
@abikouo
sanity
b453f79
@abikouo
merge with main
ac97df6
@abikouo
save
dd821f0
@abikouo
merge with main
9e8b1da
@abikouo
Merge branch 'main' of https://github.com/ansible-collections/kuberne…
e29e35d 
…tes.core into wait_arbitrary
@abikouo
updates
0a28aa0
@abikouo
Update args_common.py
4db9724
@abikouo
lint validation
2691b0f
@abikouo
fix
3939c53
@abikouo
Update k8s.py
930c551
@abikouo
attribute should match for all
483c91c
@abikouo
select wait
a20a1f6
@abikouo
Revert "select wait"
4fa6e4c 
This reverts commit a20a1f6.
@abikouo
Merge branch 'main' of https://github.com/ansible-collections/kuberne…
538d938 
…tes.core into wait_arbitrary
@abikouo
replace jmespath with builtin library
9092d6e
@abikouo
sanity
c23e3b3
@abikouo @Akasurde
Update molecule/default/tasks/waiter.yml
520e925 
Co-authored-by: Abhijeet Kasurde <[email protected]>
@abikouo
Merge branch 'main' of https://github.com/ansible-collections/kuberne…
68f34aa 
…tes.core into wait_arbitrary
@abikouo
Merge branch 'wait_arbitrary' of https://github.com/abikouo/kubernete…
8865ece 
…s.core into wait_arbitrary
@abikouo
Update jsonpath_extractor.py
7891ce8
@abikouo
Update k8s_wait_options.py
9fcd249
@abikouo
Merge branch 'wait_arbitrary' into wait_arbit_2
710a7c3
@abikouo
Merge branch 'main' of https://github.com/ansible-collections/kuberne…
cb0d965 
…tes.core into wait_arbit_2
@codecov
Copy link

codecov bot commented Jun 15, 2021 •
edited

Codecov Report

Merging #134 (8a98418) into main (46494a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
  Misses        112      112           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46494a1...8a98418. Read the comment docs.

@Akasurde
Copy link
Member

@abikouo Could you please rebase this PR? Thanks.

@abikouo
Copy link
Contributor Author

abikouo commented Jan 12, 2022

@abikouo Could you please rebase this PR? Thanks.

@Akasurde we agreed to do integrate this feature yet, so I will rebase it only when we are ready to support it

@Akasurde
Copy link
Member

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abikouo @Akasurde