vmware_cluster_ha - add set of heartbeat datastores #1732

 - name: Change APD response to "restartAggressive" again (idempotency) 

 vmware_cluster_ha: *change_apd_response 

 register: change_apd_response_again 

 - assert: 

 that: 

 - not change_apd_response_again.changed

Nina2244 · 2023-05-23T13:56:41Z

recheck

softwarefactory-project-zuul · 2023-05-23T16:40:39Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/072dc3a940654ecb8c1f29e26786c747

✔️ ansible-tox-linters SUCCESS in 8m 38s
✔️ build-ansible-collection SUCCESS in 9m 17s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 56s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 11s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 17s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 21m 45s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 44s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 59m 48s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 57m 32s
✔️ ansible-galaxy-importer SUCCESS in 3m 51s

mariolenz · 2023-05-26T07:51:17Z

@Nina2244 Finally, I found the time to test this. However, I'm not really sure if the module works as intended.

If a cluster already has a list of hearbeat datastores defined, it seems to work fine. That is, if the configured list of datastores differs from the one that is defined, this will be remediated.

But if no heartbeat datastores are configured, defining heartbeat_datastores doesn't have an effect.

On they other hand, if there is a list of heartbeat datastores configured but not defined in heartbeat_datastores, the module always reports a change. But there isn't really changed anything at all.

Nina2244 · 2023-05-26T13:28:18Z

@mariolenz really nice that you tested the other both cases. I will look for it why there is no change in both cases.

mariolenz · 2023-05-28T16:05:01Z

@Nina2244 Since I'm beginning to think that we should not introduce new parameters with default behavior (this might break existing playbooks) I wonder how this new parameter heartbeat_datastores should work. My suggestion:

If unset (None) just ignore the current list of heartbeat datastores and don't do any configuration there
If set to the empty list [] configure HA to use all datastores for heartbeat
If there are datastores configured, make sure this are the datastores HA considers to use for heartbeats

What do you think?

BTW, I think you can compare both lists directly. Or, since there's not really an order to the datastores, you might want to make a set out of them first. So you could check for set(das_config.heartbeatDatastore) == set(self.heartbeat_datastores). This way, if the vCenter reports datastores 1, 2 and 3 but the playbook defines 3, 2 and 1 there won't be a change. I'm not 100% sure, though...

…andidate policy

Nina2244 · 2023-06-21T15:20:37Z

@mariolenz i added the thing with None, and with the empty list, but I not really understand what you mean with your third point.

softwarefactory-project-zuul · 2023-06-21T15:47:43Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/46afb2a298014eb8a9087db121062e77

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 30s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 16m 23s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 44s

softwarefactory-project-zuul · 2023-06-22T16:49:49Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/48e08780aef74a8380b679910f5846bb

✔️ ansible-tox-linters SUCCESS in 9m 42s
✔️ build-ansible-collection SUCCESS in 10m 14s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 16m 43s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 18s

mariolenz · 2023-06-28T11:35:42Z

recheck

softwarefactory-project-zuul · 2023-06-28T12:09:02Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4de4d1a63833493698905d43969db91b

✔️ ansible-tox-linters SUCCESS in 8m 55s
✔️ build-ansible-collection SUCCESS in 9m 23s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 14s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 19m 53s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 21m 20s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 01s

mariolenz

The CI is still making trouble, but I hope we'll get it into 3.8.

mariolenz · 2023-06-28T14:01:00Z

plugins/modules/vmware_cluster_ha.py

+ description:
+ - A list of the heartbeat datastores.
+ - If list ist [] then all datastores of the cluster will be set as heartbeat_datastores.
+ type: list


Suggested change

type: list

version_added: '3.8.0'

type: list

mariolenz · 2023-06-28T14:01:26Z

plugins/modules/vmware_cluster_ha.py

+ - allFeasibleDs -> Automatically select datastores accessible from the hosts. Causes that C(heartbeat_datastores) will be ignored.
+ - userSelectedDs -> Use datastores only from the specified list.
+ - allFeasibleDsWithUserPreference -> Use datastores from the specified list and complement automatically if needed.
+ type: str


Suggested change

type: str

version_added: '3.8.0'

type: str

softwarefactory-project-zuul · 2023-07-19T08:02:11Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e1c3ff8cbf384ca781875bcc4fd0871b

✔️ ansible-tox-linters SUCCESS in 9m 23s
✔️ build-ansible-collection SUCCESS in 10m 21s
❌ ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006211408 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006211409 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006211410 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006211411 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 52s

softwarefactory-project-zuul · 2024-01-23T16:19:55Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0f3d260bfb204b0caa86713c733c79ce

✔️ ansible-tox-linters SUCCESS in 10m 45s
✔️ build-ansible-collection SUCCESS in 11m 17s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 24m 23s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 39s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 1h 00m 33s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 53m 48s
✔️ ansible-galaxy-importer SUCCESS in 4m 22s

softwarefactory-project-zuul · 2024-01-24T12:30:03Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/114dfb449750454289aca41f579c448a

✔️ ansible-tox-linters SUCCESS in 11m 22s
✔️ build-ansible-collection SUCCESS in 11m 44s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 42s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 20m 19s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 54m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 47m 20s
✔️ ansible-galaxy-importer SUCCESS in 4m 09s

nina.loser added 4 commits May 11, 2023 18:14

Add the possibility to set the heartbeat datastores of an cluster

8989abb

Add the changelog File

a8799c4

replace False/True with false/true

e343d4c

Add the Pull Request Nr

981647e

Missing ask for len

4744cda

add the thing @mariolenz wanted and the posibility to set the hb ds c…

e815086

…andidate policy

nina.loser and others added 2 commits June 22, 2023 09:38

self to much

97f93ab

Merge branch 'ansible-collections:main' into vmware_cluster_ha

d91984b

mariolenz requested changes Jun 28, 2023

View reviewed changes

Merge branch 'ansible-collections:main' into vmware_cluster_ha

d1f53ba

Merge branch 'ansible-collections:main' into vmware_cluster_ha

3039365

Merge branch 'ansible-collections:main' into vmware_cluster_ha

d6b8ae5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vmware_cluster_ha - add set of heartbeat datastores #1732

vmware_cluster_ha - add set of heartbeat datastores #1732

Nina2244 commented May 12, 2023

softwarefactory-project-zuul bot commented May 12, 2023

mariolenz commented May 13, 2023

softwarefactory-project-zuul bot commented May 13, 2023

Nina2244 commented May 17, 2023

softwarefactory-project-zuul bot commented May 17, 2023

mariolenz commented May 21, 2023

softwarefactory-project-zuul bot commented May 21, 2023

mariolenz commented May 22, 2023

Nina2244 commented May 23, 2023

softwarefactory-project-zuul bot commented May 23, 2023

mariolenz commented May 26, 2023

Nina2244 commented May 26, 2023

mariolenz commented May 28, 2023

Nina2244 commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 22, 2023

mariolenz commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 28, 2023

mariolenz left a comment

mariolenz Jun 28, 2023

mariolenz Jun 28, 2023

softwarefactory-project-zuul bot commented Jul 19, 2023

softwarefactory-project-zuul bot commented Jan 23, 2024

softwarefactory-project-zuul bot commented Jan 24, 2024

vmware_cluster_ha - add set of heartbeat datastores #1732

Are you sure you want to change the base?

vmware_cluster_ha - add set of heartbeat datastores #1732

Conversation

Nina2244 commented May 12, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented May 12, 2023

mariolenz commented May 13, 2023

softwarefactory-project-zuul bot commented May 13, 2023

Nina2244 commented May 17, 2023

softwarefactory-project-zuul bot commented May 17, 2023

mariolenz commented May 21, 2023

softwarefactory-project-zuul bot commented May 21, 2023

mariolenz commented May 22, 2023

Nina2244 commented May 23, 2023

softwarefactory-project-zuul bot commented May 23, 2023

mariolenz commented May 26, 2023

Nina2244 commented May 26, 2023

mariolenz commented May 28, 2023

Nina2244 commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 21, 2023

softwarefactory-project-zuul bot commented Jun 22, 2023

mariolenz commented Jun 28, 2023

softwarefactory-project-zuul bot commented Jun 28, 2023

mariolenz left a comment

Choose a reason for hiding this comment

mariolenz Jun 28, 2023

Choose a reason for hiding this comment

mariolenz Jun 28, 2023

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 19, 2023

softwarefactory-project-zuul bot commented Jan 23, 2024

softwarefactory-project-zuul bot commented Jan 24, 2024