Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proxysql version #85

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

markuman
Copy link
Member

SUMMARY

nightly ci pipeline is regulary failing

https://github.com/ansible-collections/community.proxysql/runs/4186701842?check_suite_focus=true

"msg": "Failure downloading https://github.com/sysown/proxysql/releases/download/v2.0.12/proxysql_2.0.12-ubuntu20_amd64.deb, HTTP Error 404: Not Found"

ansible-devel has moved from ubuntu 18.04 to ubuntu 20.04. But proxysql 2.0.12 was not build/available for ubuntu 20.04.
Therefore we're updating the pipeline to use the latest proxysql release 2.3.2

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Andersson007 Andersson007 merged commit 91a1f9c into ansible-collections:main Nov 12, 2021
@Andersson007
Copy link
Contributor

generally it would be nice to test against the oldest supported version of ProxySQL as well. Maybe we could implement testing on several distros and several versions? Not sure if it's achievable with GHA but with AZP it definitely is (like in c.postgresql).

@markuman
Copy link
Member Author

generally it would be nice to test against the oldest supported version of ProxySQL as well. Maybe we could implement testing on several distros and several versions? Not sure if it's achievable with GHA but with AZP it definitely is (like in c.postgresql).

Yeah, it's definitely a must-have feature that CI/CD covers more versions and distributions - and mysql connectors :) #75

@markuman
Copy link
Member Author

generally it would be nice to test against the oldest supported version of ProxySQL as well. Maybe we could implement testing on several distros and several versions? Not sure if it's achievable with GHA but with AZP it definitely is (like in c.postgresql).

Yeah, it's definitely a must-have feature that CI/CD covers more versions and distributions - and mysql connectors :) #75

...this was only a hotfix.

@Andersson007
Copy link
Contributor

generally it would be nice to test against the oldest supported version of ProxySQL as well. Maybe we could implement testing on several distros and several versions? Not sure if it's achievable with GHA but with AZP it definitely is (like in c.postgresql).

Yeah, it's definitely a must-have feature that CI/CD covers more versions and distributions - and mysql connectors :) #75

...this was only a hotfix.

Yeah, it was "a nice-to-have-in-future thing":)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants