Moved http status check up to catch more cases #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrowell
requested review from
Akasurde,
bmildren,
danxg87,
geerlingguy,
mamercad,
mpontillo and
tparker00
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When using reduced Scopes, some API calls may fail with a 403 if you didn't provide enough scopes for all of the actions being performed. This caused a crash due to some fields not existing in the response, and them being referenced before the check for the http code. I just moved the check a little bit up in the code.
ISSUE TYPE
COMPONENT NAME
digital_ocean_droplet
ADDITIONAL INFORMATION
To reproduce the error, just create a new API Key without any droplet Scopes and try to create a new droplet. Other cases relate to specific options used in the create and the scopes that the key has.