Expose more password_profile options in azure_rm_aduser

[pluto00987]

• Normalize 'password' vs 'password_profile' variable and option names
• Add options for 'force password change on next logon'

SUMMARY

This adds two additional ansible options mapping to existing options within a user's passwordProfile attribute. Specifically for my use case, I needed to be able to set forceChangePasswordNextSignIn=False.

passwordProfile resource type reference

Additionally, it normalizes the option and variable names so that 'password' is a password and 'password_profile' is a PasswordProfile object.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

azure_rm_aduser

ADDITIONAL INFORMATION

[Fred-sun]

kindly ping!

[Fred-sun]

@pluto00987 Why do you have to redefine parameters that already exist? This has a large impact on the current user -- ‘password_profile'. You are advised not to change the previous parameter names. There is also a slight problem with the documentation. Thank you!

[pluto00987]

@Fred-sun
I opted to change the parameter name because 'password_profile' is a misnomer IMO. I did however leave it as an alias for 'password' which should prevent breaking any existing ansible jobs.
This was my same thought with the code. 'Password' is a thing and 'password profile' is also a thing but the existing variable names were mismatched with what they actually contained.
What issue with the documentation?

[Fred-sun]

@pluto00987 This will affect the current user. In this case, please fix the problem described in the above document. As for changing the parameter name, we will discuss it internally. Thank you!

[Fred-sun]

@pluto00987 There are no other questions, please make changes to the above part of the document. Thank you!

[Fred-sun]

Small change requests!

[Fred-sun]

kindly ping!

[Fred-sun]

Kindly ping!

[pluto00987]

Hello Fred-sun.
I applied your change and rebased to current upstream. Please let me know if anything further is needed.
Thank you!

[pluto00987]

Fred-sun, I made an error with the first rebase but have corrected it now.

[Fred-sun]

@xuzhang3 ready_for_review!

[pluto00987]

@Fred-sun I see a problem. The password option is in fact already used elsewhere, in azure_rm_common.py. I didn't realize this before but happened to be looking at the module documentation page today, where it is listed. So I can't rename password_profile to password after all.

So I will need to refactor this patch. I still don't like the name password_profile but I suppose leaving the original name alone is easiest. I'm open to other suggestions though. It's unfortunate that whomever implemented the global ad_user/password options didn't use ad_password instead for consistency, but such is life.

[Fred-sun]

@pluto00987 Yes, you are right that it should not duplicate the integrated parameter name. After you resubmit, I will review and promote the merger as soon as possible! Thank you!

[pluto00987]

Hi @Fred-sun. I've updated the change. Please take a look now. Thank you!