rds_cluster: add support for I/O-Optimized storage configuration for aurora clusters #2063
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/rds_cluster_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/rds_cluster_module.html
index 2ad4874..5644e9c 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/rds_cluster_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/rds_cluster_module.html
@@ -916,11 +916,15 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-rds-clus
</div></td>
<td><div class="ansible-option-cell"><p>Specifies the storage type to be associated with the DB cluster.</p>
<p>This setting is required to create a Multi-AZ DB cluster.</p>
-<p>When specified, a value for the <em>iops</em> parameter is required.</p>
-<p>Defaults to <code class="docutils literal notranslate"><span class="pre">io1</span></code>.</p>
+<p>For multi-AZ DB clusters, <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-rds-cluster-module-parameter-storage-type"><span class="std std-ref"><span class="pre">storage_type</span></span></a></strong></code> defaults to <code class="ansible-value docutils literal notranslate"><span class="pre">io1</span></code> and a value for the <code class="ansible-value docutils literal notranslate"><span class="pre">iops</span></code> parameter is required.</p>
+<p>For Aurora DB clusters, <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-rds-cluster-module-parameter-storage-type"><span class="std std-ref"><span class="pre">storage_type</span></span></a></strong></code> defaults to <code class="ansible-value docutils literal notranslate"><span class="pre">aurora</span></code> standard.</p>
+<p>For mysql and postgres DB clusters, <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-rds-cluster-module-parameter-storage-type"><span class="std std-ref"><span class="pre">storage_type</span></span></a></strong></code> defaults to <code class="ansible-value docutils literal notranslate"><span class="pre">io1</span></code>.</p>
+<p>Support for <code class="ansible-value docutils literal notranslate"><span class="pre">aurora</span></code> and <code class="ansible-value docutils literal notranslate"><span class="pre">aurora-iopt1</span></code> was added in release 8.1.0.</p>
<p class="ansible-option-line"><strong class="ansible-option-choices">Choices:</strong></p>
<ul class="simple">
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"io1"</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"aurora"</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"aurora-iopt1"</span></code></p></li>
</ul>
</div></td>
</tr>
|
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 47s |
GomathiselviS
requested review from
a team,
gravesm,
jillr,
hakbailey,
alinabuzachis,
GomathiselviS and
abikouo
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
e49f461
to
d38569d
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 58s |
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
2d84ddd
to
097bacd
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 22s |
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
097bacd
to
db7aac9
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 55s |
| @@ -118,10 +118,49 @@ | |||
| that: | |||
| - not _result_create_db_cluster.changed | |||
|
|
|||
| # aurora-iopt1 test | |||
There was a problem hiding this comment.
Can you please check also that storage_type defaults to aurora when it is not specified and the engine is aurora?
There was a problem hiding this comment.
Verified manually that it Sets config to
Cluster storage configuration
Aurora Standard
The issue with the tasks for amazon.aws.rds_cluster and amazon.aws.rds_cluster_info is, they do not return storage_type when storage_type param is not set or even when set storage_type=aurora.
Also tried with aws cli command, however does not return StorageType as well https://docs.aws.amazon.com/cli/latest/reference/rds/describe-db-clusters.html
There was a problem hiding this comment.
If you handle the defaults in the module logic, instead of leaving them to the API, you should be able to access the returned parameters (like here https://github.com/ansible-collections/amazon.aws/pull/2063/files#diff-41d80755edc72340b8c75ea1d8c215e8e9b974de3ffe70e2bd0538c37baa2f0aR1329).
There was a problem hiding this comment.
tried handling as suggested, still unable to get the value of stroage_type in return values.
probably I'm missing something?
There was a problem hiding this comment.
Okay, I understand. I also tried with different versions of botocore. We should probably add a note in the RETURN block for the storage type. Does this behavior occur with the default storage type value on aurora engines or also on mysql/postgres?
@tremble Any suggestions?
There was a problem hiding this comment.
@alinabuzachis @tremble considering that api does not return the required value/param, and the I have manually verified the results, should we revert this and continue to progress the pr?
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 45s |
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
5c0abe2
to
55d85ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
55d85ef
to
1ac2e41
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
1ac2e41
to
6ed2bf6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
6ed2bf6
to
13a43ea
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
13a43ea
to
acfb347
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
acfb347
to
770a272
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
770a272
to
6f91772
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
437696a
to
cfc0203
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
d4d47a9
to
e2ecf30
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
e2ecf30
to
f29f59a
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 56s |
…ge config as aurora-standard
mandar242
force-pushed
the
rds_cluster_storage_type_support_upadte
branch
from
f29f59a
to
54618ac
Compare
SUMMARY
Adds support for I/O-Optimized storage configuration for aurora clusters
Fixes #2038
ISSUE TYPE
COMPONENT NAME
rds_cluster
ADDITIONAL INFORMATION