Don't ignore IPv6 addresses when a single network interface is specified #1979
Conversation
|
@maggu Thanks for taking the time to submit this PR. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to? |
|
@alinabuzachis Thanks for the reply and feedback. Regarding integration tests, there appear to currently be no tests at all for checking ec2_instance network settings. What do you think would be the most appropriate approach for this? Adding it to ec2_instance_instance_*? Creating a new ec2_instance_network to test network settings? Something else, like ipv6_tests to test ivp6 settings across multiple modules? |
|
@alinabuzachis Changelog fragment added, and rebased to current main. I believe that integration tests might need a wider scope than this PR, considering that currently similar functionality isn't tested and there's no obvious place to add it. Such tests would obviously be beneficial though. |
alinabuzachis
added
backport-7
|
@maggu If you can rebase this PR, we can merge it. |
|
regate |
softwarefactory-project-zuul
bot
merged commit 0d1a604
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2112 🤖 @patchback |
…ied (#1979) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2113 🤖 @patchback |
…ied (#1979) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604)
…ied (#1979) (#2113) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604) Co-authored-by: C C Magnus Gustavsson <[email protected]>
…ied (#1979) (#2112) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604) Co-authored-by: C C Magnus Gustavsson <[email protected]>
SUMMARY
When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION