Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tooltip): Tooltip should mark for check when visibility … #29000

Merged
merged 1 commit into from
May 7, 2024

Commits on May 4, 2024

  1. fix(material/tooltip): Tooltip should mark for check when visibility …

    …changes
    
    This commit fixes an error in the tooltip component where it updates
    a value used in a host binding without calling `markForCheck`. This does
    not currently throw an error because `checkNoChanges` is broken for
    `OnPush` components. However, the error was surfaced when testing an
    "exhaustive" check that will check _all_ views, regardless of their
    dirty state. The issue also doesn't really produce a _visible_ problem
    because it occurs when the tooltip is hidden so the fact that the zoom
    never updates doesn't make a real difference.
    atscott committed May 4, 2024
    Configuration menu
    Copy the full SHA
    67d97cd View commit details
    Browse the repository at this point in the history