fix(multiple): move afterRender calls back outside zone #28981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
jelbourn,
crisbeto and
devversion
as code owners
crisbeto
approved these changes
May 1, 2024
Updates some calls to afterRender / afterNextRender to explicitly run outside the NgZone. These usages were originally explcitily run outside, but the explicit call was removed when they were updated to use the afterRender / afterNextRender function, since at the time it was automatically outside the zone. The semantics of afterRender / afterNextRendef have since changed so this is no longer true. Therefore this PR restores the original explicit run outside.
mmalerba
added
the
blocked
|
There are plans in the works to put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates some calls to afterRender / afterNextRender to explicitly run outside the NgZone. These usages were originally explcitily run outside, but the explicit call was removed when they were updated to use the afterRender / afterNextRender function, since at the time it was automatically outside the zone. The semantics of afterRender / afterNextRendef have since changed so this is no longer true. Therefore this PR restores the original explicit run outside.