-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to v7: More complete example #2962
base: master
Are you sure you want to change the base?
Conversation
connectEmulator does not exist. It's connectFirestoreEmulator. Also I've added an example for all the others. Including auth which has different arguments (port is included in the URL)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I'm having a hard time migrating to v7 to be honest. Looking into Firebase-sdk and rxfire docs to find how it's supposed to work. Hopefully this doc update will make it easier to someone |
I have recently migrated Some of the issues I have encountered:
|
Documentation is pending. @hakimio include metadata changes was enabled in AngularFire v6, I don't think the behavior is dramatically different as rxfire was a copy/paste from angularfire. If you're having troubles feel free to remain on compat, it will be supported for some time. rxfire has duplicate naming because of legacy reasons, it was pure functions before JS SDK was. It was prior art in the new API design. As always this is an open source project & only one of my many responsibilities; please keep it constructive and we welcome pull requests. |
@jamesdaniels
|
@hakimio I didn't take it as mean, just saying that we're open source, time constrained, and we welcome help. In general I think a lot of folk think that these libraries are well staffed and that we have all the resources in the world, but even over on our side of the fence this is a volunteers-only project. A) At the time this was designed, we didn't have configuration that could be passed into snapshotChanges, ultimately we decided that B) that would be a break & would require a major, changing docs, confusing people on older versions; ultimately we didn't have time to do that (as I was on paternity leave) before JS SDK v9 dropped. We had a mad rush to move over all the docs, cut a bunch of libraries, are still playing wack a mole with edge cases, while also trying to find time to take some time off so we don't burn out 😝 I consider rxfire a dependency of AngularFire still at this point (rather than a peer) and don't care if we diverge, I'd rather developers not have to consider our internal implementation. This is only problematic right now while we're working on the AF docs. If you see any bugs with docs or implementation please file issues and we welcome PRs. |
connectEmulator does not exist. It's connectFirestoreEmulator. Also I've added an example for all the others. Including auth which has different arguments (port is included in the URL)