Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: uwu #55666

Closed
wants to merge 1 commit into from
Closed

docs: uwu #55666

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

馃檭

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 3, 2024
@ngbot ngbot bot added this to the Backlog milestone May 3, 2024
@JeanMeche JeanMeche force-pushed the docs/uwu branch 2 times, most recently from 6d6910e to adb1462 Compare May 3, 2024 20:33
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited

Deployed adev-preview for 71b53d8 to: https://ng-dev-previews-fw--pr-angular-angular-55666-adev-prev-p8uex7n2.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche marked this pull request as ready for review May 3, 2024 20:50
@JeanMeche JeanMeche requested review from mgechev and twerske May 3, 2024 20:51
@mgechev
Copy link
Member

mgechev commented May 3, 2024

There's a bit of a rough initial flicker when you open the page. We'd like to show the right logo as part of the prerendered page. I guess this gets a little tricky without redirects.

@JeanMeche JeanMeche force-pushed the docs/uwu branch 10 times, most recently from b9014de to 9fbe9ea Compare May 3, 2024 23:46
bencodezen
bencodezen approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I was actually thinking of doing this too. Thanks for the PR!

@bencodezen bencodezen added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 6, 2024
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate state: blocked and removed target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 6, 2024
@AndrewKushnir
Copy link
Contributor

Waiting for an LGTM from @mgechev or @twerske (added the "blocked" label for now).

@mgechev mgechev added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels May 7, 2024
@AndrewKushnir AndrewKushnir removed the request for review from twerske May 7, 2024 21:30
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 7287fef.

AndrewKushnir pushed a commit that referenced this pull request May 7, 2024
@JeanMeche @AndrewKushnir
docs: uwu (#55666)
e701672 
PR Close #55666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

@bencodezen bencodezen bencodezen approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeanMeche @mgechev @AndrewKushnir @bencodezen