fix(platform-browser): Use the right namespace for mathML. #55665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
May 3, 2024
yarn.lock
Outdated
| @@ -16707,6 +16707,11 @@ [email protected]: | |||
| resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.2.tgz#0ae9cebcfae970718474fe0da2c090cad6577372" | |||
| integrity sha512-+2/g0Fds1ERlP6JsakQQDXjZdZMM+rqpamFZJEKh4kwTIn3iDkgKtby0CeNd5ATNZ4Ry1ax15TMx0W2V+miizQ== | |||
|
|
|||
| [email protected]: | |||
There was a problem hiding this comment.
There was a mismatch in the lock file. The 17.3.x branch is currently red because of this.
JeanMeche
force-pushed
the
mathml
branch
4 times, most recently
from
fc83ac1
to
dc29633
Compare
JeanMeche
force-pushed
the
mathml
branch
3 times, most recently
from
95b54e6
to
d23cf3b
Compare
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM `Element`. This commit fixes this.
|
This is now in the LTS branch. We could still merge it if you want, but we don't often backport this kind of thing. |
dylhunn
approved these changes
May 22, 2024
|
It's probably not worth shipping a patch for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, MathML element were created with the wrong namespace resulting in regular DOM
Element.This commit fixes this.
This is a backport of #55622 into 17.3