Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small updates to zoneless docs #55636

Closed
wants to merge 1 commit into from
Closed

docs: small updates to zoneless docs #55636

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented May 2, 2024

No description provided.

@atscott atscott added the target: rc This PR is targeted for the next release-candidate label May 2, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 2, 2024
@atscott atscott requested a review from bencodezen May 2, 2024 14:57
@ngbot ngbot bot added this to the Backlog milestone May 2, 2024
@atscott atscott added adev: preview and removed area: docs Related to the documentation labels May 2, 2024
@ngbot ngbot bot removed this from the Backlog milestone May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited

Deployed adev-preview for a06ed12 to: https://ng-dev-previews-fw--pr-angular-angular-55636-adev-prev-79mx5f1o.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 2, 2024
@ngbot ngbot bot added this to the Backlog milestone May 2, 2024
bencodezen
bencodezen requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it was a spelling error or you meant to add another word, but after that clarification, happy to approve and mark as ready for merge!

@bencodezen bencodezen added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 2, 2024
@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 3, 2024
@atscott atscott requested a review from bencodezen May 3, 2024 21:23
bencodezen
bencodezen approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @atscott!

@bencodezen bencodezen added the action: merge The PR is ready for merge by the caretaker label May 6, 2024
@ngbot
Copy link

ngbot bot commented May 6, 2024

I see that you just added the action: merge label, but the following checks are still failing:
聽聽聽聽failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 464dae9.

AndrewKushnir pushed a commit that referenced this pull request May 6, 2024
@atscott @AndrewKushnir
docs: small updates to zoneless docs (#55636)
3de1bc6 
PR Close #55636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnizet jnizet jnizet left review comments

@bencodezen bencodezen bencodezen approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atscott @AndrewKushnir @jnizet @bencodezen