Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add redirect banner to adev page #55626

Closed
wants to merge 1 commit into from
Closed

docs: add redirect banner to adev page #55626

wants to merge 1 commit into from

Conversation

twerske
Copy link
Contributor

@twerske twerske commented May 1, 2024 •
edited

Links to the most relevant ADEV page in the mapping

CARETAKER NOTE:
This needs to be patched into at least v17.angular.io to link to Angular.dev, since the banners on each one don't currently match.

@twerske twerske added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer aio: preview target: patch This PR is targeted for the next patch release labels May 1, 2024
@twerske twerske added this to the Angular.dev is stable! milestone May 1, 2024
@twerske twerske requested a review from josephperrott May 1, 2024 23:31
@ngbot ngbot bot modified the milestone: Angular.dev is stable! May 1, 2024
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 1, 2024
@ngbot ngbot bot added this to the Backlog milestone May 1, 2024
@twerske twerske added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed state: blocked target: patch This PR is targeted for the next patch release labels May 21, 2024
josephperrott
josephperrott previously approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twerske twerske added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 21, 2024
@dylhunn dylhunn added PullApprove: disable and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 21, 2024
@dylhunn dylhunn self-requested a review May 21, 2024 21:14
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit b10e031.

dylhunn pushed a commit that referenced this pull request May 21, 2024
@twerske @dylhunn
docs: add redirect banner to adev page (#55626)
b10e031 
PR Close #55626
@dylhunn dylhunn closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylhunn dylhunn dylhunn approved these changes

@josephperrott josephperrott josephperrott left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker aio: preview area: docs Related to the documentation PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Angular.dev is stable!
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twerske @dylhunn @josephperrott