Remove unused JSNAMESPACE_SUPPORT from event-dispatch #55619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
added
the
requires: TGP
rahatarmanahmed
changed the title
AndrewKushnir
approved these changes
May 1, 2024
The usage of this option has been removed from google3 code, so we don't need to keep it around anymore.
rahatarmanahmed
force-pushed
the
no-jsnamespace-attr
branch
from
7422e84
to
dc4fd4e
Compare
|
Caretaker note: cl/630174160 is needed either in sync CL or prior to sync CL due to copybara changes. |
|
TESTED=TGP (failures are extremely flaky and fail at HEAD) |
rahatarmanahmed
added
the
action: merge
AndrewKushnir
added
target: rc
AndrewKushnir
approved these changes
May 6, 2024
AndrewKushnir
added
the
merge: caretaker note
|
Caretaker note: this PR is ready for merge, the only missing piece was an additional |
|
This PR was merged into the repository by commit 8795374. |
rahatarmanahmed
added a commit
to rahatarmanahmed/angular
that referenced
this pull request
May 14, 2024
Support for the jsnamespace attribute was removed in angular#55619.
12 tasks
dylhunn
pushed a commit
that referenced
this pull request
May 17, 2024
dylhunn
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an old feature that let you add
jsnamespace="nsto an element to implicitly add thens.namespace to all unnamespaced JSAction handlers on or under that element. This required an expensive DOM walk to find the jsnamespace, and almost all JSAction users turned this feature off. The last usage in google 3was removed, so we can delete this now.PR Checklist
Please check if your PR fulfills the following requirements:
addeddeleted (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What kind of change does this PR introduce?