Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove AIO from search indexing #55618

Closed
wants to merge 1 commit into from
Closed

docs: remove AIO from search indexing #55618

wants to merge 1 commit into from

Conversation

twerske
Copy link
Contributor

@twerske twerske commented May 1, 2024

Open question: Should this be cherry picked into all previous v17 branches to ensure only Angular.dev is indexable on Search going forwards?

@twerske twerske added state: blocked target: major This PR is targeted for the next major release labels May 1, 2024
@twerske twerske added this to the Angular.dev is stable! milestone May 1, 2024
@ngbot ngbot bot removed this from the Angular.dev is stable! milestone May 1, 2024
@twerske twerske requested a review from josephperrott May 1, 2024 19:11
@pullapprove pullapprove bot requested a review from AndrewKushnir May 1, 2024 19:11
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 1, 2024
@ngbot ngbot bot added this to the Backlog milestone May 1, 2024
@twerske twerske added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed state: blocked target: major This PR is targeted for the next major release labels May 21, 2024
josephperrott
josephperrott previously approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylhunn dylhunn removed the request for review from AndrewKushnir May 21, 2024 20:42
@twerske twerske changed the base branch from 17.3.x to main May 21, 2024 20:52
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 21, 2024
@twerske twerske changed the base branch from main to 17.3.x May 21, 2024 20:56
@twerske twerske dismissed josephperrott’s stale review May 21, 2024 20:56

The base branch was changed.

@pullapprove pullapprove bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label May 21, 2024
@twerske twerske added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 21, 2024
dylhunn pushed a commit that referenced this pull request May 21, 2024
@twerske @dylhunn
docs: remove AIO from search indexing (#55618)
d83dda5 
PR Close #55618
@dylhunn
Copy link
Contributor

dylhunn commented May 21, 2024

This PR was merged into the repository by commit d83dda5.

@dylhunn dylhunn closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylhunn dylhunn dylhunn approved these changes

@josephperrott josephperrott josephperrott left review comments

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation PullApprove: disable target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Angular.dev is stable!
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twerske @dylhunn @josephperrott