Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): support ~ path for dev-server ssl #27595

Closed
wants to merge 2 commits into from

Conversation

titan-ron
Copy link

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When utilizing the @angular-devkit/build-angular:dev-server (serve) builder for local development of applications with SSL, it's not possible to set a default value in the project configuration using ~. Instead, you must specify it through arguments, move it to the workspace, or wrap the Angular builder.

Issue Number: N/A

What is the new behavior?

This PR will manage the use of ~ for the sslCert and sslKey options.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label May 3, 2024
@titan-ron titan-ron marked this pull request as ready for review May 3, 2024 13:39
@alan-agius4 alan-agius4 requested a review from clydin May 3, 2024 15:22
@alan-agius4
Copy link
Collaborator

Hey @titan-ron, thank you for your contribution. We discussed and whilst the tilde expansion is a common feature in Unix-like systems, such as Bash shells. Therefore, we prefer keeping it separate from the configuration to avoid potential inconsistencies.

@alan-agius4 alan-agius4 closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants