#185 Fixing critical vulnerabilities on 2.0.0-beta.2, caused by [email protected] #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isahann
changed the title
|
Thank you so much, Isahann! @JohannesHoppe will review and merge this one. |
JohannesHoppe
requested changes
May 8, 2024
|
@isahann Thanks for starting this PR! 😃 🙏 Do you think you have the resources to figure out how we can address the breaking change? |
I've just downloaded the repo, haven't checked much of it besides the package.json and the breaking test.... But I'll try to take a better look into it... |
|
We have holidays in Germany. I will run all tests on Monday! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just upgraded to the latest version of
gh-pagesavailable at the moment.After upgrading, removed the
node_modules,package-lock.json, and then ran a freshnpm i.Building with
npm buildruns just fine. And after fixing a single test,npm test(building first) passes all tests too.Please feel free to request any changes.