Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-input-rename] incorrectly triggers on input transforms #1809

Merged
merged 7 commits into from
May 21, 2024

Conversation

ptu14
Copy link
Contributor

@ptu14 ptu14 commented May 7, 2024

closes #1446

@ptu14 ptu14 changed the title fix: incorrectly triggers on input transforms fix: [@angular-eslint/no-input-rename] incorrectly triggers on input transforms May 7, 2024
@ptu14 ptu14 force-pushed the bugfix/1446-no-input-rename branch from c70de00 to c1496b8 Compare May 7, 2024 09:20
Copy link

nx-cloud bot commented May 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1aa96e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.46%. Comparing base (4a042ec) to head (1aa96e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.01%     
==========================================
  Files         178      178              
  Lines        3339     3345       +6     
  Branches      534      536       +2     
==========================================
+ Hits         3020     3026       +6     
  Misses        185      185              
  Partials      134      134              
Flag Coverage Δ
unittest 90.46% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eslint-plugin/tests/rules/no-input-rename/cases.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-input-rename.ts 89.39% <83.33%> (+1.06%) ⬆️

@JamesHenry JamesHenry changed the title fix: [@angular-eslint/no-input-rename] incorrectly triggers on input transforms fix(eslint-plugin): [no-input-rename] incorrectly triggers on input transforms May 21, 2024
JamesHenry
JamesHenry previously approved these changes May 21, 2024
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ptu14!

@JamesHenry JamesHenry merged commit 4de165d into angular-eslint:main May 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/no-input-rename] incorectly triggers on input transforms
3 participants