Custom optional custom file. #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace any of the 2 compiling vars for nginx with custom values and retain them over updates if file is ignored.
Merge latest changes from source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I can't say I love bash but I've modified the script to support the optional load of a file nginx-custom.options that can include any of both of your NGINX_MODULES and NGINX_OPTIONS variables.
This allows to personalise the standard compile modules (was my case) without loosing the possibility to update your script or having to modify it again as I've add it to the git ignore list. Left a "sample" one.
Feel free to include it if you find it of interest.
I've had to redo it as I've noticed you've, just today, modified considerably the code. Is done in any case although I'll admit I liked better your previous "echo" style and log interface.
By the way I only found this today which is not updated but might be of interest to you too: https://github.com/naologic/nginx-builder