-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx-1.23.1 mainline version has been released & Bugfix ngx_headers_… etc #243
base: master
Are you sure you want to change the base?
Conversation
…more Changes with nginx 1.23.0 21 Jun 2022 *) Change in internal API: now header lines are represented as linked lists. *) Change: now nginx combines arbitrary header lines with identical names when sending to FastCGI, SCGI, and uwsgi backends, in the $r->header_in() method of the ngx_http_perl_module, and during lookup of the "$http_...", "$sent_http_...", "$sent_trailer_...", "$upstream_http_...", and "$upstream_trailer_..." variables. *) Bugfix: if there were multiple "Vary" header lines in the backend response, nginx only used the last of them when caching. *) Bugfix: if there were multiple "WWW-Authenticate" header lines in the backend response and errors with code 401 were intercepted or the "auth_request" directive was used, nginx only sent the first of the header lines to the client. *) Change: the logging level of the "application data after close notify" SSL errors has been lowered from "crit" to "info". *) Bugfix: connections might hang if nginx was built on Linux 2.6.17 or newer, but was used on systems without EPOLLRDHUP support, notably with epoll emulation layers; the bug had appeared in 1.17.5. Thanks to Marcus Ball. *) Bugfix: nginx did not cache the response if the "Expires" response header line disabled caching, but following "Cache-Control" header line enabled caching. Bugfix ngx_headers_more : openresty/headers-more-nginx-module@91eb0db I edited the file in my browser, I know that HEADERMOD_VER is now unused. I was unsure, If I should have apply the bugfix only, but since the last release of this module is 2017, I think that is fine with the current context. Compilation is now working properly on my side. nginx -V nginx version: nginx/1.22.0 built by gcc 10.2.1 20210110 (Debian 10.2.1-6) built with OpenSSL 1.1.1n 15 Mar 2022 TLS SNI support enabled configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --user=nginx --group=nginx --with-cc-opt=-Wno-deprecated-declarations --with-cc-opt=-Wno-ignored-qualifiers --with-threads --with-file-aio --with-http_ssl_module --with-http_v2_module --with-http_mp4_module --with-http_auth_request_module --with-http_slice_module --with-http_stub_status_module --with-http_realip_module --with-http_sub_module --add-module=/usr/local/src/nginx/modules/ngx_brotli --add-module=/usr/local/src/nginx/modules/headers-more-nginx-module However, before this was not the case unfortunately.
ModPageSpeed seems to be not liking Mainline 1.23.0 |
Hello! When is the 1.23 expected to be fixed? |
Changes with nginx 1.23.1 19 Jul 2022 *) Feature: memory usage optimization in configurations with SSL proxying. *) Feature: looking up of IPv4 addresses while resolving now can be disabled with the "ipv4=off" parameter of the "resolver" directive. *) Change: the logging level of the "bad key share", "bad extension", "bad cipher", and "bad ecpoint" SSL errors has been lowered from "crit" to "info". *) Bugfix: while returning byte ranges nginx did not remove the "Content-Range" header line if it was present in the original backend response. *) Bugfix: a proxied response might be truncated during reconfiguration on Linux; the bug had appeared in 1.17.5.
Everything is absolutely fine for me. nginx -V |
IDK what CI is doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed
/usr/local/src/nginx/modules/ngx_http_geoip2_module-3.3/ngx_http_geoip2_module.c: In function ‘ngx_http_geoip2_variable’:
/usr/local/src/nginx/modules/ngx_http_geoip2_module-3.3/ngx_http_geoip2_module.c:172:14: error: assignment to ‘ngx_array_t *’ from incompatible pointer type ‘ngx_table_elt_t **’ {aka ‘struct ngx_table_elt_s **’} [-Werror=incompatible-pointer-types]
172 | xfwd = &r->headers_in.x_forwarded_for;
| ^
/usr/local/src/nginx/modules/ngx_http_geoip2_module-3.3/ngx_http_geoip2_module.c:175:58: error: passing argument 3 of ‘ngx_http_get_forwarded_addr’ from incompatible pointer type [-Werror=incompatible-pointer-types]
175 | (void) ngx_http_get_forwarded_addr(r, &addr, xfwd, NULL,
| ^~~~
| |
| ngx_array_t *
Does this include the PCRE2 Problem with the LUA module, as found here #248 ? |
No, unfortunately the only time I used LUA with the script (December 2021) it was not working properly. |
hey looking to use this on my server but I need a nginx version bump again |
Couldn't have said better myself 🤣 |
Changes with nginx 1.23.0 21 Jun 2022
Bugfix ngx_headers_more :
openresty/headers-more-nginx-module@91eb0db
I edited the file in my browser, I know that HEADERMOD_VER is now unused. I was unsure, If I should have apply the bugfix only, but since the last release of this module is 2017, I consider that this is fine with the current context.
Compilation is now working properly on my side.
nginx -V
nginx version: nginx/1.22.0
built by gcc 10.2.1 20210110 (Debian 10.2.1-6)
built with OpenSSL 1.1.1n 15 Mar 2022
TLS SNI support enabled
configure arguments: --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --user=nginx --group=nginx --with-cc-opt=-Wno-deprecated-declarations --with-cc-opt=-Wno-ignored-qualifiers --with-threads --with-file-aio --with-http_ssl_module --with-http_v2_module --with-http_mp4_module --with-http_auth_request_module --with-http_slice_module --with-http_stub_status_module --with-http_realip_module --with-http_sub_module --add-module=/usr/local/src/nginx/modules/ngx_brotli --add-module=/usr/local/src/nginx/modules/headers-more-nginx-module
However, before this was not the case unfortunately.