Add TypeScript typings for core & webpack #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej guys 馃憢
I started tackling #246, for now only
@webpack-blocks/core
&@webpack-blocks/webpack
to have a foundation, so we can discuss naming etc.Afterwards we just need to add the proper
index.d.ts
to the blocks.If I'm not mistaken there shouldn't be other changes necessary, at least VSCode gave me type hints in the sample app already, but I'll list some here for research:
typings
topackage.json
(should be obsolete, as we comply toindex.d.ts
convention)index.d.ts
towebpack-blocks
which exports types from sub-modules (should be infered from sub-module typings)@types/
needs to be installed manually