Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create collection #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create collection #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0e7cda
WIP: create collection
stefangweichinger Jun 21, 2021
c1727b4
WIP: correct path
stefangweichinger Jun 21, 2021
0a79140
WIP: add meta info
stefangweichinger Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

# check Python syntax
- name: Python syntax check
run: python3 -m py_compile lxc_ssh.py
run: python3 -m py_compile plugins/lxc_ssh/lxc_ssh.py


# prepare container with LXD installation
Expand Down Expand Up @@ -272,7 +272,7 @@ jobs:
run: ansible --version

- name: Install plugin for tests
run: cp -af $GITHUB_WORKSPACE/lxc_ssh.py $GITHUB_WORKSPACE/tests/connection_plugins/lxc_ssh.py
run: cp -af $GITHUB_WORKSPACE/plugins/lxc_ssh/lxc_ssh.py $GITHUB_WORKSPACE/tests/connection_plugins/lxc_ssh.py

- name: Create empty file for tests
run: touch $GITHUB_WORKSPACE/tests/test_empty.txt
Expand Down
15 changes: 15 additions & 0 deletions galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
authors:
- TODO
dependencies:
"ansible.netcommon": ">=2.0.1"
license_file: LICENSE
name: lxc_ssh
namespace: ansible
description: Ansible Network Collection for LXC containers and hosts
readme: README.md
repository: https://github.com/my_org/my_collection"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasscherbaum as an example: I only created the framework, the actual content has to be reviewed and edited. You as current maintainer know best, right? ;-)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefangweichinger Ah, I actually never created a collection :-( Have to admit that.
How about I leave this until all the other PRs are merged, and then we look over this one as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that was also my plan. I just wanted to see if the tests still work and which changes are needed, etc.

tags: [lxc, lxd, networking]
# NOTE(pabelanger): We create an empty version key to keep ansible-galaxy
# happy. We dynamically inject version info based on git information.
version: null
2 changes: 2 additions & 0 deletions meta/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
requires_ansible: '>=2.9.10'
0 ansible.mk → plugins/lxc_ssh/ansible.mk
View file
Open in desktop
File renamed without changes.
0 lxc_ssh.py → plugins/lxc_ssh/lxc_ssh.py
View file
Open in desktop
File renamed without changes.
0 pyproject.toml → plugins/lxc_ssh/pyproject.toml
View file
Open in desktop
File renamed without changes.
3 changes: 3 additions & 0 deletions plugins/lxc_ssh/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[pycodestyle]
statistics = True
max-line-length = 89