This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Fix compilation on openSUSE #1998
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leviathanch Looks like your branch contains other camera related changes too. I guess your intention was not to include them in this PR, right? |
|
Hi
No just this patch, the other stuff is still work in progress :-)
Cheers
David
…On Sunday, February 13, 2022 10:05:40 AM WET Simon Fels wrote:
@leviathanch Looks like your branch contains other camera related changes
too. I guess your intention was not to include them in this PR, right?
|
|
@leviathanch so those camera commits aren't intented for this PR? |
|
Nope. Just really only that one patch I've proposed to merge, so that RPMs
build through on openSUSE...
The camera support still is buggy and it turns out that's because of some
more serious issue with the Hudini libraries which cause an "has unexpected
e_machine: 183" error right now, because cross platform support with binfmt
isn't working yet and that messes up the entire process of accessing the
camera for some reason... and Revolut doesn't start, which was the only
reason I went onto that endeavour.
Cheers
-lev
…On Monday, February 14, 2022 4:30:31 AM WET Rahammetoela Toekiman wrote:
@leviathanch so those camera commits aren't intented for this PR?
|
|
the camera commits ended up as a part of this PR, you may want to remove them |
|
Oops... |
|
Fixed it |
|
Is this commit also intended to be part of this PR 000df0d @leviathanch? |
|
Yeah. Because otherwise Anbox doesn't work with the current LXC version openSUSE |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
On openSUSE those small changes are needed for successfully building an RPM.
Please consider pulling this patch.
Thanks!