This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Added cmake-extras to dependencies- Fixes some build from source issues #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deals with cmake not finding installed libraries
Not all build of ubuntu ship with libelf-dev and libdwarf-dev included. Specifically on arm they are not included.
|
The above update to the pull request adds missing dependencies for certain distribution of ubuntu, such as certain arm and aarch64 LTS builds |
as above-
At times the repo fails to pull down cpu_features. The above adds a clear and concise way of dealing with that scenario without cluttering up the existing documentation
add troubleshooting and solution for python 2 default version
|
Added troubleshooting steps to building android to deal with the typical default of python 2 on some distributions of ubuntu |
morphis
suggested changes
Apr 25, 2021
|
this is extremely useful, been having issues that relate to this. Cheers!! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still useful |
|
Request new review and potential up-streaming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deals with cmake not finding installed libraries such as gmock
#1707 #1662 #1616
TLDR; it seems that the way things were set up made the assumption that cmakes-extras was installed.
this issue was found when comparing docker dependencies in #1723 #1258