Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Optionally use installed sdbus-cpp library #1733

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optionally use installed sdbus-cpp library #1733

wants to merge 3 commits into from

Conversation

jnnks
Copy link
Contributor

@jnnks jnnks commented Jan 21, 2021

This PR implements a compile-once solution for the external project sdbus-cpp used for the docker container build toolchain.
The installed library is used instead of building the in-tree module when it can be found with cmake find_package.
A fallback was implemented to avoid build errors in case the library is not installed on the host.

This is a small study to reduce build times by providing precompiled resources before Anbox is built.
The performance improvement is for niche use cases where the entire project is fully rebuild multiple times.

By introducing other concepts, the overall build time is reduced anyways. For example docker BuildKit, which reduces the buld time for the anbox-build image.

job master (s) this PR (s) diff (master - PR in s)
scripts/build.sh 60.41 59.51 0.9
scripts/build-with-docker.sh 61.28 60.15 1.13
scripts/build-with-docker.sh (docker --no-cache) 163.44 156.99 6.45

When accepted this will be a reference implementation with the other external modules following in the same style.

@morphis In src/CMakeLists.txt the include path for sdbus-cpp is hardcoded. I would like to use something like sdbus-c++_INLCUDE_DIRS, but the variable was empty. Do you know a work-around?

@Niek
Copy link

Niek commented Mar 30, 2021

@stale
Copy link

stale bot commented Aug 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the decaying label Aug 3, 2021
@Fuseteam
Copy link

What is this missing?

@stale stale bot removed the decaying label Nov 26, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the decaying label Apr 16, 2022
@Fuseteam
Copy link

Still sounds useful...

@stale stale bot removed the decaying label Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants