Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve intro paragraph for Astro integration #1092

Merged

Conversation

BoogieMonsta
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 14, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit f4b152f
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/664312d4b2ce66000829310b
😎 Deploy Preview https://deploy-preview-1092--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit f4b152f
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/664312d4b6e50f0008d37e53
😎 Deploy Preview https://deploy-preview-1092--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit f4b152f
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/664312d4aa663300088ebff8
😎 Deploy Preview https://deploy-preview-1092--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit f4b152f
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/664312d41424c90008346247
😎 Deploy Preview https://deploy-preview-1092--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BoogieMonsta
Copy link
Contributor Author

Hey @brandonroberts! Sorry, I'm not clear on whether I should merge this into beta or main. But I'm happy to make the change if I got it wrong!

@brandonroberts brandonroberts changed the title Astro integration: improve intro paragraph docs: improve intro paragraph for Astro integration May 14, 2024
@brandonroberts brandonroberts merged commit e4479f5 into analogjs:beta May 14, 2024
24 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @BoogieMonsta for doc

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @BoogieMonsta! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants