Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added example in docs of using a resolver for metatags for markdown component (#1014) #1082

Merged
merged 5 commits into from
May 21, 2024

Conversation

AmGarera
Copy link
Contributor

@AmGarera AmGarera commented May 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #1014

What is the new behavior?

A new Example added to the docs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 66b5d27
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/664c017dea0f6600089a5fd2
😎 Deploy Preview https://deploy-preview-1082--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 66b5d27
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/664c017daddf3200083ba745
😎 Deploy Preview https://deploy-preview-1082--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 66b5d27
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/664c017d3a0a7f000869aa45
😎 Deploy Preview https://deploy-preview-1082--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 66b5d27
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/664c017d4cfe09000828a73c
😎 Deploy Preview https://deploy-preview-1082--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
apps/docs-app/docs/features/routing/content.md Outdated Show resolved Hide resolved
@brandonroberts
Copy link
Member

@AmGarera are you still interested in landing these changes?

@AmGarera
Copy link
Contributor Author

Yeah I should get sometime later today to address your requested changes.

@brandonroberts brandonroberts merged commit 40af6e1 into analogjs:beta May 21, 2024
24 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @AmGarera for doc

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @AmGarera! 🎉

@AmGarera AmGarera deleted the docs/issue-1014 branch May 24, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: add example of using a resolver for metatags for markdown component
2 participants