Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork ResizeObserver polyfill to support shadow DOM and FIE #31850

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fork ResizeObserver polyfill to support shadow DOM and FIE #31850

merged 2 commits into from
Jan 8, 2021

Conversation

dvoytenko
Copy link
Contributor

Partial for #31540.

See que-etc/resize-observer-polyfill#79 for more details.

@dvoytenko dvoytenko requested a review from samouri January 7, 2021 23:33
@samouri
Copy link
Member

samouri commented Jan 8, 2021

nit: rename from upgrade to fork ?

@dvoytenko dvoytenko changed the title Upgrade ResizeObserver polyfill to support shadow DOM and FIE Fork ResizeObserver polyfill to support shadow DOM and FIE Jan 8, 2021
@dvoytenko
Copy link
Contributor Author

nit: rename from upgrade to fork ?

done

samouri
samouri approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we'd potentially be better served by promoting this to its own repo? E.g. ampproject/resize-observer-polyfill

@dvoytenko
Copy link
Contributor Author

Do you think we'd potentially be better served by promoting this to its own repo? E.g. ampproject/resize-observer-polyfill

We will do it if we do not get the response. But I think the rule of thumb for now is to give a few weeks before forking.

@dvoytenko dvoytenko merged commit 4209fe9 into ampproject:master Jan 8, 2021
@dvoytenko dvoytenko deleted the run3/resize-obs-sd branch January 8, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @samouri @ampprojectbot