Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create commandbar-cohort.md #348

Merged
merged 11 commits into from
May 24, 2024
Merged

Conversation

Brandoncharleskhoo1
Copy link
Contributor

This is the shared google doc that I have with CommandBar

https://docs.google.com/document/d/1-Ofyy68SpLOj-hJOwFerTWaxgKgfC-soD5xnSEL3Wxw/edit

Amplitude Developer Docs PR

Description

Describe your changes.

Deadline

When do these changes need to be live on the site?

Change type

  • Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
  • Doc update.
  • New documentation.
  • Non-documentation related fix or update.

PR checklist:

  • My documentation follows the style guidelines of this project.
  • I previewed my documentation on a local server using mkdocs serve.
  • Running mkdocs serve didn't generate any failures.
  • I have performed a self-review of my own documentation.

@amplitude-dev-docs

Copy link

github-actions bot commented May 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 2 0 0.21s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-348.d19s7xzcva2mw3.amplifyapp.com

@Brandoncharleskhoo1
Copy link
Contributor Author

@markzegarelli i don't know why the value error is coming up. Can you please help with this?

@markzegarelli
Copy link
Member

@Brandoncharleskhoo1 Not sure why Vale's confused by CommandBar. No issues from my side. Feel free to merge.

@Brandoncharleskhoo1 Brandoncharleskhoo1 merged commit 4bbc6ed into main May 24, 2024
4 of 5 checks passed
@Brandoncharleskhoo1 Brandoncharleskhoo1 deleted the Brandoncharleskhoo1-patch-14 branch May 24, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants