Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dsg): move dsg version log up to be one of the first build log entry #8454

Merged
merged 4 commits into from May 14, 2024

Conversation

overbit
Copy link
Contributor

@overbit overbit commented May 10, 2024

Closes #7463

PR Details

Rename the dsg in the package name and move the DSG version log to be one of the first and consistent with the other generators (i.e. https://github.com/amplication/generator-dotnet-webapi/commit/6f1c795830508a2aff200e336f82a884eb71413a)

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented May 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 96aab19. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@overbit overbit linked an issue May 10, 2024 that may be closed by this pull request
@overbit overbit changed the base branch from next to master May 14, 2024 09:36
@overbit overbit merged commit 996d6e7 into master May 14, 2024
5 checks passed
@overbit overbit deleted the feat/7463 branch May 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-service-generator version in build log should be more visible
2 participants