Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BTM - Commit validations - avoid double dialog on top of each other #8032

Open
mulygottlieb opened this issue Feb 18, 2024 · 3 comments · May be fixed by #8100
Open

BTM - Commit validations - avoid double dialog on top of each other #8032

mulygottlieb opened this issue Feb 18, 2024 · 3 comments · May be fixed by #8100
Assignees
@morhag90

Comments

@mulygottlieb
Copy link
Member

Currently, as part of the commit button validations, you can get an error dialog opened on top of another dialog.
The expectation is that the bottom dialog will close when displaying the top dialog.

Related to: #7959

Image
@mulygottlieb mulygottlieb mentioned this issue Feb 18, 2024
Closed
@PazYanoverr
Copy link
Member

@mulygottlieb - Is it possible to display the error / the problem in the same "Your new arch is ready" dialog?

@mulygottlieb mulygottlieb assigned morhag90 and abrl91 and unassigned abrl91 Feb 20, 2024
@morhag90 morhag90 linked a pull request Feb 22, 2024 that will close this issue
Draft
2 tasks
@morhag90 morhag90 linked a pull request Feb 25, 2024 that will close this issue
fix(client): fix double dialog BTM for committing limitation error #8100
Draft
2 tasks
@mulygottlieb
Copy link
Member Author

@morhag90 let's hold with this ticket for now, and we will release the first BTM release without fixing this issue and then fix it properly (with moving the commit logic to hook, etc.)
FYI @PazYanoverr

@mulygottlieb
Copy link
Member Author

Since the commit button itself issues the top dialog, the correct fix IMO is to extract the commit button logic into a hook and use the hook from both the commit button and the BTM dialog. Since this requires some regression testing for the commit button and is sensitive, I estimate the total work with testing in 2 days. Therefore, we decided to backlog it for now.
(@morhag90 @PazYanoverr )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morhag90 morhag90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client): fix double dialog BTM for committing limitation error amplication/amplication
4 participants
@mulygottlieb @abrl91 @morhag90 @PazYanoverr