Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTM- Enforce existing commit validations in the confirmation modal #7959

Closed
PazYanoverr opened this issue Feb 7, 2024 · 6 comments · Fixed by #7992
Closed

BTM- Enforce existing commit validations in the confirmation modal #7959

PazYanoverr opened this issue Feb 7, 2024 · 6 comments · Fixed by #7992
Assignees

Comments

@PazYanoverr
Copy link
Member

Implement the existing commit button (as a component)
Build the code button - add delay until build starts

@morhag90 morhag90 linked a pull request Feb 12, 2024 that will close this issue
2 tasks
@abrl91
Copy link
Member

abrl91 commented Feb 18, 2024

✅ passed QA

Image

@PazYanoverr
Copy link
Member Author

@mulygottlieb @abrl91 - Isn't it just the same not-ideal behavior of two dialogs?

@mulygottlieb
Copy link
Member

@PazYanoverr yes. I think it's not a blocker for the release (definitely not the one we want for today), and I have advised Amit that we should open a separate ticket for that. Your call.

@PazYanoverr
Copy link
Member Author

Agreed. Let's open a new ticket (not blocker)

@mulygottlieb
Copy link
Member

@abrl91 did you already open a new ticket for the double dialog or should I?

@mulygottlieb
Copy link
Member

@PazYanoverr I opened #8032 to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants