Rename parseFieldValueComponents to parseMultipleHeaderFields
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatibility to http v2.0.0-beta.3)
|
Tests fixed |
kelunik
reviewed
Apr 15, 2023
src/Rfc6455Connector.php
Outdated
| @@ -111,7 +111,7 @@ private function generateRequest(WebsocketHandshake $handshake, string $key): Re | |||
| $request->setTlsHandshakeTimeout($handshake->getTlsHandshakeTimeout()); | |||
| $request->setHeaderSizeLimit($handshake->getHeaderSizeLimit()); | |||
|
|
|||
| $extensions = \array_column(Http\parseFieldValueComponents($request, 'sec-websocket-extensions') ?? [], 0, 0); | |||
| $extensions = \array_column(Http\parseMultipleHeaderFields($request, 'sec-websocket-extensions') ?? [], 0, 0); | |||
There was a problem hiding this comment.
We can use parseHeaderTokens here.
|
Need tag of amphp/http-server |
trowski
reviewed
Apr 15, 2023
| self::DEFAULT_CONNECTIONS_PER_IP_LIMIT | ||
| ); | ||
|
|
||
| $httpServer = new SocketHttpServer($logger, $serverSocketFactory, $clientFactory); |
There was a problem hiding this comment.
You can use SocketHttpServer::createForDirectAccess() instead.
kelunik
reviewed
Apr 15, 2023
| @@ -71,7 +71,7 @@ public function connect(WebsocketHandshake $handshake, ?Cancellation $cancellati | |||
| return; | |||
| } | |||
|
|
|||
| $extensions = \array_column(Http\parseMultipleHeaderFields($response, 'sec-websocket-extensions') ?? [], 0, 0); | |||
| $extensions = \array_column(Http\parseHeaderTokens($response, 'sec-websocket-extensions') ?? [], 0, 0); | |||
There was a problem hiding this comment.
array_column can and should be dropped then, no?
|
I need to get this merged so that I can update all http-* packages in my project to the latest version. Currently, this pull request is blocking any further updates to the http-* packages since this package also relies on http v2. What can I do to help move this along? Happy to open another PR if needed. |
|
Resolved by 24daf3c and tagged in 2.0.0 Beta 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility to http v2.0.0