Adjust some tests for Windows CI

amphp · Dec 27, 2023 · 75cfed9 · 75cfed9
1 parent 0a0ab6b
commit 75cfed9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,6 +29,9 @@ jobs:
  php-extensions: parallel
  job-description: 'with ext-parallel'
  php-ts: ts
+ static-analysis: none
+ style-fix: none
+ composer-require-checker-version: none
  continue-on-error: true
 
  - operating-system: 'ubuntu-latest'
@@ -42,7 +45,7 @@ jobs:
  continue-on-error: true
 
  - operating-system: 'macos-latest'
- php-version: '8.2'
+ php-version: '8.3'
  job-description: 'on macOS'
  php-ts: nts
  continue-on-error: false

diff --git a/test/Worker/AbstractPoolTest.php b/test/Worker/AbstractPoolTest.php
@@ -11,6 +11,7 @@
 use Amp\Parallel\Worker\Task;
 use Amp\Parallel\Worker\Worker;
 use Amp\Parallel\Worker\WorkerPool;
+use const Amp\Process\IS_WINDOWS;
 
 abstract class AbstractPoolTest extends AbstractWorkerTest
 {
@@ -108,6 +109,10 @@ public function testCreatePoolShouldThrowError(): void
 
  public function testCleanGarbageCollection(): void
  {
+ if (IS_WINDOWS) {
+ $this->markTestSkipped('Skipping on Windows for now');
+ }
+
  // See https://github.com/amphp/parallel-functions/issues/5
  for ($i = 0; $i < 3; $i++) {
  $pool = $this->createPool(32);
@@ -158,7 +163,7 @@ public function testWaitingForAvailableWorker(): void
  $delay = 0.1;
 
  $this->setMinimumRuntime($delay * $count);
- $this->setTimeout($delay * $count * 2);
+ $this->setTimeout($delay * $count * 3);
 
  $pool = $this->createPool(1);
 

diff --git a/test/Worker/AbstractWorkerTest.php b/test/Worker/AbstractWorkerTest.php
@@ -122,6 +122,8 @@ public function testSubmitMultipleThenShutdown(): void
  $worker->submit(new Fixtures\TestTask(72, 0.1))->getFuture(),
  ];
 
+ delay(0);
+
  // Send shutdown signal, but don't await until tasks have finished.
  $shutdown = async(fn () => $worker->shutdown());
 
@@ -134,8 +136,8 @@ public function testNotIdleOnSubmit(): void
  {
  $worker = $this->createWorker();
 
- $future = $worker->submit(new Fixtures\TestTask(42))->getFuture();
- delay(0); // Tick event loop to call Worker::submit()
+ $future = $worker->submit(new Fixtures\TestTask(42, 0.5))->getFuture();
+ delay(0.1); // Tick event loop to call Worker::submit()
  self::assertFalse($worker->isIdle());
  $future->await();