Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NO_OVERWRITE config option #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for NO_OVERWRITE config option #97

wants to merge 1 commit into from

Conversation

Chaz6
Copy link

@Chaz6 Chaz6 commented Aug 9, 2021

No description provided.

@amietn
Copy link
Owner

amietn commented Aug 14, 2021

Thank you for contributing!

I believe this does not work if no_overwrite is set to False in the config file. It would still be interpreted as True.

One solution would be to call config.getboolean() instead of config.get() for options of boolean type.

@Chaz6
Copy link
Author

Chaz6 commented Aug 15, 2021

Thank you for the feedback, I will amend the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chaz6 @amietn