Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firstStepDeceleration prop in scrollOverflowOptions #3217

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jnotnull
Copy link

@jnotnull jnotnull commented Apr 27, 2018

1- Make sure to commit it to the dev branch!
2- Read https://github.com/alvarotrigo/fullPage.js/wiki/Contributing-to-fullpage.js

  1. USAGE:
$('#fullpage').fullpage({
    scrollOverflow: true,
    scrollOverflowOptions: {
        firstStepDeceleration: true
        deceleration: 0.0024,
    }
});
  1. WHY

If i use scrollOverflow property, some sections maybe overflow if sections larger than viewport height, but other sections maybe not overflow. if i slide from section which is not overflow to section which is over flow, the speed of first roll is too fast at overflow section, because people maybe do not know this section is overflow if he slide forcefully. if i use firstStepDeceleration property, it may be more smoothly.

@jnotnull jnotnull changed the title Add scrollOverflowOptions prop firstStepDeceleration Add prop firstStepDeceleration in scrollOverflowOptions Apr 27, 2018
@jnotnull jnotnull changed the title Add prop firstStepDeceleration in scrollOverflowOptions Add firstStepDeceleration prop in scrollOverflowOptions Apr 27, 2018
@alvarotrigo
Copy link
Owner

alvarotrigo commented Apr 27, 2018

Thanks for that!
Could you please provide a jsfiddle example and the steps to reproduce it in ordrr to illustrate the issue you are attempting to solve?

if i slide from section which is not overflow to section which is over flow, the speed of first roll is too fast at overflow section

I can't seem to reproduce it here:
https://jsfiddle.net/1kyuL4em/46/

Are you talking about sliding with the mouse wheel and trackpad? Or about touch devices?
I'm using a trackpad and everything seems alright to me.

@jnotnull
Copy link
Author

jnotnull commented Apr 28, 2018

Ok, thanks for your example, your example is enough for me.

If i am a coder, i know first section is fullpage, the second section is overflow, i maybe sliding my finger not hard when i enter the second section.

But if i am a user, i dont know the second section is overflow, i just know sliding my finger hard because human's thinking is linear. If i sliding hard when i at second section, this section is scroll so fast that sometimes i cant see the content clearly. If i add firstStepDeceleration prop, sometimes it can change people's linear thinking, i maybe know i cant slide hard.

@alvarotrigo
Copy link
Owner

Are you talking about sliding with the mouse wheel and trackpad? Or about touch devices?

@jnotnull
Copy link
Author

It is touch device, just iphone 8 plus.

@alvarotrigo
Copy link
Owner

I was playing a bit with this but I was not able to notice any difference.
I tried using both, kinetic scrolling trackpad (Macbook pro) and and iPhone 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants