Features/extensionmethods for interface types #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theses changes allow to do fluent syntax when working with the interface types instead of the explicit types. The ceveat is, that because these methods always create a new Result object, we might lose the covariance here.
ResultExtensions only contains extensions for Task<…> and Value<…> objects. All Extensions for IResult<TValue> are now in IResultTExtensions. IResultTExtensions is directly in Namespace FluentResults. New method "MapReasons()". Makes it easier to implement MapErros and MapSuccesses. The overloads of Bind implemented by one method that is called from the other overloads. There are two variants. Bind() that returns Result without value and Bind() that returns Result with value. Return value is always directly Result or Result<TValue> except for "MapErrors", because MapErrors can return the IResult<TValue> argument directly. All other methods always create a new object as return value.
seems a better name, also avoids letting a class start with an I.
Adds methods, that are else defined in ResultBase, so that they are also available for IResultBase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds methods that are defined in
ResultBase,ResultBase<TResult>andResult<TValue>as extensions methods for eitherIResultBaseorIResult<TValue>.See also: #192