Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cv.liquid #2297

Closed
wants to merge 1 commit into from
Closed

Update cv.liquid #2297

wants to merge 1 commit into from

Conversation

AneeshBose
Copy link

@AneeshBose AneeshBose commented Mar 26, 2024

Added Table of Contents to cv which was there in earlier versions, but missing in current version

Added Table of Contents which was there in earlier versions, but missing in current version
@alshedivat
Copy link
Owner

I'm not sure if table of contents was removed intentionally or accidentally. @george-gca, do you know?

@george-gca
Copy link
Collaborator

I don't remember now, but I believe it was removed since it currently already displays a table of contents on the side, as can be seen on the demo site.

@AneeshBose
Copy link
Author

I don't remember now, but I believe it was removed since it currently already displays a table of contents on the side, as can be seen on the demo site.

The toc by the side does not look visually appealing and the text seems to bleed out for me, not sure if the others are facing the same. Which is why I had to revert to adding the toc in the beginning. If there is a picture I can help with, please let me know!

@george-gca
Copy link
Collaborator

the text seems to bleed out for m

What do you mean? For me it looks like this, and it seems fine:
image

@alshedivat
Copy link
Owner

closing since toc on side works as expected

@alshedivat alshedivat closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants