Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7694] Fix fuzzy search with underscore returns wrong results #7695

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gaoliang
Copy link

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #7694 Fuzzy search with underscore returns wrong results

Brief changelog

Escape underscore when query data with generateLikeArgument function.

For derby, an additional statement specifying the escape character is required, so add a

SQL_DERBY_ESCAPE_BACK_SLASH_FOR_LIKE = " ESCAPE '\\' "

see https://db.apache.org/derby/docs/10.5/ref/rrefjdbc28456.html

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2022

CLA assistant check
All committers have signed the CLA.

@lizzy810
Copy link

lizzy810 commented Sep 3, 2022

I can help you developer out on the issue

@stale
Copy link

stale bot commented Jun 18, 2023

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label Jun 18, 2023
@EnomaPeter
Copy link

Full access

@stale stale bot removed the expired No active for a long time label Apr 2, 2024
@EnomaPeter
Copy link

Uploading IMG_6238.jpeg…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzzy search with underscore returns wrong results
5 participants