[ISSUE#12022] Fix nacos datasource plugin ClassCastException bug (#12… #12031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
requested changes
Apr 29, 2024
| @@ -43,7 +43,15 @@ public class MapperProxy implements InvocationHandler { | |||
|
|
|||
| public <R> R createProxy(Mapper mapper) { | |||
| this.mapper = mapper; | |||
| return (R) Proxy.newProxyInstance(MapperProxy.class.getClassLoader(), mapper.getClass().getInterfaces(), this); | |||
| Class<?> clazz = mapper.getClass(); | |||
| while (clazz.getInterfaces().length == 0) { | |||
There was a problem hiding this comment.
这个逻辑是否也有风险？ 现在这个实现的逻辑是找到第一个interfaces不为0的类/或父类， 如果插件实现的时候自己定义了一个接口，然后那个接口也不是Mapper的子类或接口，应该也会出现ClassCase异常。
看下是否把所有的这个传入的mapper的所有interface都获取出来，然后让Proxy代理上？
如果没必要的话， 只需要找到实现了Mapper的对应class，然后再获取这个类的interfaces来动态代理。
There was a problem hiding this comment.
确实，这点是我考虑不周了，如果插件在实现的时候有自己的接口，这里也会报错。
拿实现了Mapper的对应class的interfaces，目前看来足够使用了，nacos中调用findMapper()也用不到插件自己实现的接口。
KomachiSion
previously approved these changes
May 6, 2024
|
CI seems can't pass， please check and fix them |
KomachiSion
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix nacos datasource plugin ClassCastException bug https://github.com/alibaba/nacos/issues/12022
Brief changelog
Modify the clazz.getInterfaces() method in com.alibaba.nacos.plugin.datasource.proxy.MapperProxy#createProxy so that clazz can obtain the correct Class<?>[] interface
Verifying this change
After repair, nacos can run normally without ClassCastException and does not affect the original mysql mapper.
postgersql：
mysql：
