Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11967] Can not aquire the specific config #12025

Merged
merged 5 commits into from May 15, 2024

Conversation

syshenyao
Copy link
Contributor

BUG:#11967 details refer: #10119 & #10101

@KomachiSion
Copy link
Collaborator

Error: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project nacos-config: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/nacos/nacos/config/target/rat.txt -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project nacos-config: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/nacos/nacos/config/target/rat.txt

One file new has no copyright, please add copyright to file header.

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@syshenyao
Copy link
Contributor Author

Error: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project nacos-config: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/nacos/nacos/config/target/rat.txt -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project nacos-config: Too many files with unapproved license: 1 See RAT report in: /home/runner/work/nacos/nacos/config/target/rat.txt

One file new has no copyright, please add copyright to file header.

Okay

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case seems not pass

before start run test with encoder, might set the os system as window to triggle encoder and reset the os system after case finished.

@syshenyao
Copy link
Contributor Author

The test case seems not pass

before start run test with encoder, might set the os system as window to triggle encoder and reset the os system after case finished.

I tried modifying it, but it had no effect.

@KomachiSion
Copy link
Collaborator

The test case seems not pass
before start run test with encoder, might set the os system as window to triggle encoder and reset the os system after case finished.

I tried modifying it, but it had no effect.

I think you should find out the problem, why it is not effect and fix it.

@syshenyao
Copy link
Contributor Author

The test case seems not pass
before start run test with encoder, might set the os system as window to triggle encoder and reset the os system after case finished.

I tried modifying it, but it had no effect.

I think you should find out the problem, why it is not effect and fix it.

done

@KomachiSion KomachiSion merged commit 6fe4363 into alibaba:develop May 15, 2024
7 checks passed
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Config labels May 15, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants