[ISSUE #10377] Migrating Client OpenTelemetry trace from dynamic proxies to delegate classes #11559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to fix some problems about dynamic proxies in PR #11138
The dynamic proxy solution used in the previous PR has problems with backward compatibility.
In order to solve this problem, this PR turns to inheritance or interface implementation to complete the OpenTelemetry trace packaging of the client's main logic class.
Fix issue #10377
Brief changelog
ClientWorkerTraceDelegate: Delegate theClientWorkerby inheritanceConfigRpcTransportClientProxyTraceDelegate: Delegate theConfigRpcTransportClientby implementingConfigRpcTransportClientProxysinceConfigRpcTransportClientis an anonymous inner classServerHttpAgentTraceDelegate: Delegate theServerHttpAgentby inheritanceNamingClientProxyTraceDelegate: Delegate all theNamingClientProxyinterfaceNamingGrpcRedoServiceTraceDelegate: Delegate theNamingGrpcRedoServiceby inheritanceVerifying this change
Unit tests are provided for all delegate classes