Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong dom event interface due to typo. #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong dom event interface due to typo. #339

wants to merge 1 commit into from

Conversation

Joouis
Copy link

@Joouis Joouis commented Aug 30, 2019

Currently DOM event key is "domEvent" but named as "domeEvent" in interface, it will block tsc build for type checking. This commit will fix this typo.

image

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Joouis Joouis changed the title Fix typo of dom event. Fix wrong dom event interface due to typo. Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants