-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connectFrequentlyBoughtTogether): implement sendEvent #6128
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b97118a:
|
if (results === null || results === undefined) { | ||
return { hits: [], widgetParams }; | ||
return { hits: [], sendEvent, widgetParams }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Dhaya, as far as I know, queryID are only available on search query (not recommend queries).
I think the queryID mentioned here does not relate to recommend.
I would be in favour of not doing anything in particular regarding events yet. The current recommend libraries have the intention of adding it, but don't currently have it. I'll request changes for this, but let me know if I'm confused about this.
Moving this back to draft for now (see discussion thread). |
b7755fa
to
828d0cb
Compare
828d0cb
to
b9d90b5
Compare
Summary
This PR backports the changes in 8498792 to the relevant branch where it impacts the connector.